Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(dashboard): update TiDB Dashboard to v8.4.0-6a0d342d [master] #8581

Merged
merged 9 commits into from
Sep 5, 2024
Merged

chore(dashboard): update TiDB Dashboard to v8.4.0-6a0d342d [master] #8581

merged 9 commits into from
Sep 5, 2024

Conversation

baurine
Copy link
Contributor

@baurine baurine commented Aug 28, 2024

What problem does this PR solve?

Issue Number: ref #4257

Update TiDB Dashboard to v8.4.0-6a0d342d.

Release note

None

@ti-chi-bot ti-chi-bot bot added release-note-none Denotes a PR that doesn't merit a release note. dco-signoff: yes Indicates the PR's author has signed the dco. labels Aug 28, 2024
@ti-chi-bot ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Aug 28, 2024

Hi @baurine. Thanks for your PR.

I'm waiting for a tikv member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@ti-chi-bot ti-chi-bot bot added needs-ok-to-test Indicates a PR created by contributors and need ORG member send '/ok-to-test' to start testing. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Aug 28, 2024
@mornyx
update conf
e9bdcd9 
Signed-off-by: mornyx <[email protected]>
@rleungx
Copy link
Member

rleungx commented Aug 28, 2024

/ok-to-test

@ti-chi-bot ti-chi-bot bot added ok-to-test Indicates a PR is ready to be tested. and removed needs-ok-to-test Indicates a PR created by contributors and need ORG member send '/ok-to-test' to start testing. labels Aug 28, 2024
@ti-chi-bot ti-chi-bot bot added needs-1-more-lgtm Indicates a PR needs 1 more LGTM. approved size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed approved size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Aug 28, 2024
@codecov Codecov
Copy link

codecov bot commented Aug 28, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 77.60%. Comparing base (193fe6c) to head (ff0a74a).
Report is 1 commits behind head on master.

Additional details and impacted files 
@@            Coverage Diff             @@
##           master    #8581      +/-   ##
==========================================
- Coverage   77.69%   77.60%   -0.10%     
==========================================
  Files         474      474              
  Lines       61851    61852       +1     
==========================================
- Hits        48055    47998      -57     
- Misses      10266    10312      +46     
- Partials     3530     3542      +12
Flag Coverage Δ
unittests 77.60% <100.00%> (-0.10%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

@ti-chi-bot ti-chi-bot bot added lgtm and removed needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Aug 28, 2024
@ti-chi-bot ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Aug 28, 2024

[LGTM Timeline notifier]

Timeline:

  • 2024-08-28 06:08:09.94723098 +0000 UTC m=+936885.081681102: ☑️ agreed by rleungx.
  • 2024-08-28 07:44:00.704996609 +0000 UTC m=+942635.839446731: ☑️ agreed by lhy1024.

@mornyx
Copy link
Contributor

mornyx commented Aug 28, 2024

/cc @niubell PTAL, thanks. This PR adds a new configuration to TiDB dashboard.

@ti-chi-bot ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Sep 5, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: lhy1024, niubell, rleungx

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added the approved label Sep 5, 2024
@ti-chi-bot ti-chi-bot bot merged commit a4ae781 into tikv:master Sep 5, 2024
25 checks passed
@mornyx mornyx deleted the update-tidb-dashboard/master-v8.4.0-6a0d342d-1724822747 branch September 5, 2024 03:10
@mornyx mornyx mentioned this pull request Sep 9, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rleungx rleungx rleungx approved these changes

@lhy1024 lhy1024 lhy1024 approved these changes

@niubell niubell niubell approved these changes

Assignees
No one assigned
Labels
approved dco-signoff: yes Indicates the PR's author has signed the dco. lgtm ok-to-test Indicates a PR is ready to be tested. release-note-none Denotes a PR that doesn't merit a release note. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@baurine @rleungx @mornyx @niubell @lhy1024